[PATCH 6/6] mtd: s3c2410: Fix line over 80 characters warning
Sachin Kamat
sachin.kamat at linaro.org
Tue Aug 21 00:51:27 EDT 2012
Hi Artem,
Thanks for your review.
On 19 August 2012 16:41, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> On Mon, 2012-07-16 at 16:02 +0530, Sachin Kamat wrote:
>> @@ -540,7 +540,8 @@ static void s3c2412_nand_enable_hwecc(struct mtd_info *mtd, int mode)
>> unsigned long ctrl;
>>
>> ctrl = readl(info->regs + S3C2440_NFCONT);
>> - writel(ctrl | S3C2412_NFCONT_INIT_MAIN_ECC, info->regs + S3C2440_NFCONT);
>> + writel(ctrl | S3C2412_NFCONT_INIT_MAIN_ECC,
>> + info->regs + S3C2440_NFCONT);
>
> This patch makes the code look uglier and less readable. Please, align
> the part which you move to thenext line with the opening bracket ("(").
> The current code uses this style as well.
Yes, you are right.
I will send the updated patch.
>
> I did not take this patch.
>
> --
> Best Regards,
> Artem Bityutskiy
--
With warm regards,
Sachin
More information about the linux-mtd
mailing list