[PATCH 1/2] mtd: esb2rom: convert to MFD model

Artem Bityutskiy dedekind1 at gmail.com
Fri Aug 17 07:48:06 EDT 2012


On Thu, 2012-07-12 at 16:50 -0500, Aaron Sierra wrote:
> Move esb2rom PCI device scanning to lpc_ich.
> 
> Signed-off-by: Aaron Sierra <asierra at xes-inc.com>

For me this patch is too big to review. Can you split it, but still keep
bisectable? Also, the commit message should be more sensible and should
explain what you do, how, and which problem you solved, and how you
tested this.

Why the MFD list is not CCed?

> +MODULE_ALIAS("platform:" KBUILD_MODNAME);

Does this have to be in this patch? Looks like an independent change.

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120817/a95134c3/attachment.sig>


More information about the linux-mtd mailing list