Kernel crashes when CONFIG_MTD_NAND_VERIFY_WRITE=y

Marek Vasut marex at denx.de
Thu Aug 9 22:11:21 EDT 2012


Dear Huang Shijie,

> 于 2012年08月10日 09:49, Fabio Estevam 写道:
> > On Thu, Aug 9, 2012 at 10:41 PM, Marek Vasut<marex at denx.de>  wrote:
> >> NAK! This is only a workaround, proper implementation is needed. If it's
> >> not implemented now, I'm pretty sure such workaround will be there
> >> forever.
> > 
> > I know, please see below.
> > 
> >>>   /*
> >>>   
> >>>    * Handles block mark swapping.
> >>>    * It can be called in swapping the block mark, or swapping it back,
> >>> 
> >>> @@ -1568,6 +1577,7 @@ static int __devinit gpmi_nfc_init(struct
> >>> gpmi_nand_data *this)
> >>> 
> >>>          chip->ecc.size          = 1;
> >>>          chip->ecc.strength      = 8;
> >>>          chip->ecc.layout        =&gpmi_hw_ecclayout;
> >>> 
> >>> +       chip->verify_buf        = gpmi_verify_buf;
> >>> 
> >>>          if (of_get_nand_on_flash_bbt(this->dev->of_node))
> >>>          
> >>>                  chip->bbt_options |= NAND_BBT_USE_FLASH |
> >>>                  NAND_BBT_NO_OOB;
> >>> 
> >>> Now we need to come up with a real  gpmi_verify_buf function ;-)
> 
> I does have a real gpmi_verify_buf function in our BSP code.
> 
> I will send it out as soon as possible.

I believe you should roll it out ASAP and also CC stable!

> thanks
> Huang Shijie
> 
> > As I mentioned, I understand that a proper function needs to be created.
> > 
> > Regards,
> > 
> > Fabio Estevam

Best regards,
Marek Vasut



More information about the linux-mtd mailing list