[PATCH 2/7] jffs2reader: eliminate compiler errors

Brian Norris computersforpeace at gmail.com
Tue Sep 20 17:11:16 EDT 2011


On Mon, Sep 19, 2011 at 4:25 AM, Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
> -#define DIRENT_INO(dirent) ((dirent)!=NULL?(dirent)->ino:0)
> -#define DIRENT_PINO(dirent) ((dirent)!=NULL?(dirent)->pino:0)
> +#define DIRENT_INO(dirent) ((dirent)!=NULL?je32_to_cpu((dirent)->ino):0)
> +#define DIRENT_PINO(dirent) ((dirent)!=NULL?je32_to_cpu((dirent)->pino):0)

Can you include proper spacing around the '!=', '?', and ':'
operators? It's easier to read.

Otherwise, I don't know the specifics on JFSS2-endianness, but the
motivation looks good...

Brian



More information about the linux-mtd mailing list