[PATCH 03/14] mtd: define `is_ecc_error()' macros

Artem Bityutskiy dedekind1 at gmail.com
Tue Sep 20 03:19:45 EDT 2011


On Mon, 2011-09-19 at 11:43 -0700, Brian Norris wrote:
> Right, I hadn't settled on a name yet and so I haven't rewritten the patches.
> 
> I like the fact that your names are shorter. I'm not sure about
> `mtd_is_bitflip_or_eccerr()', though; the compound name seems a little
> out of place. But maybe it's just better to be clear on exactly what
> is covered by the function. Is there a broad category name for
> bitflips/ECC errors? I just consider them corrected/uncorrected errors
> in flash, thus the naming I gave.
> 
> I'll either repost with a better naming scheme or update my patches
> with the suggested names.

OK, let's do this sooner than later please, to make sure I have all your
work in my tree, which is safer (consider the situation when dwmw2 picks
what I have now and upstreams before we put everything in).

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list