[PATCH 02/14] mtd: nand: do not ignore all ECC errors

Artem Bityutskiy dedekind1 at gmail.com
Sun Sep 11 09:58:21 EDT 2011


On Wed, 2011-09-07 at 13:13 -0700, Brian Norris wrote:
> There are a few reasons not to ignore ECC errors here.
> 
> First, mtd->read_oob is being called in raw mode, so there should be no
> error correction in the first place.
> 
> Second, if we change this such that there *is* error correction in this
> function, then we will want to pass the error message upward.
> 
> In fact, the code I introduced to "ignore ECC errors" would have been
> better if it had just placed this test down in `scan_block_full()' in
> the first place. We would like to ignore ECC errors when we are simply
> checking for bad block markers (e.g., factory marked), but we may not
> want to ignore ECC errors when scanning OOB for a flash-based BBT
> pattern (in `scan_read_raw()'; note that the return codes from
> `scan_read_raw()' are not actually handled yet).
> 
> Signed-off-by: Brian Norris <computersforpeace at gmail.com>

Pushed to my tree, thanks!

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list