[PATCH] phram: make kernel boot command line arguments work

Jörn Engel joern at logfs.org
Tue Oct 25 15:58:58 EDT 2011


On Tue, 25 October 2011 11:09:02 +0200, Fache, Herve wrote:
> On Tue, Oct 25, 2011 at 09:37, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> > Yeah, I thought checkpatch.pl would blame you for improper comments
> > style. The standard way to write comments is described in
> > Documentation/CodingStyle.
> 
> I have to admit I just re-used the original patch's comments. Do they
> need to be changed prior to merging?

Nah!  Your patch is a clear improvement.  If the worst offence of your
patch is that you moved code around that had an undesired (but still
quite common) comment style, you are in good shape. ;)

Jörn

-- 
Everything should be made as simple as possible, but not simpler.
-- Albert Einstein



More information about the linux-mtd mailing list