[PATCH] phram: make kernel boot command line arguments work

Fache, Herve h-fache at ti.com
Fri Oct 21 04:49:29 EDT 2011


Hi Artem,

On Thu, Oct 20, 2011 at 18:20, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
>
> On Mon, 2011-10-17 at 17:40 +0200, h-fache at ti.com wrote:
>
> > -static int phram_setup(const char *val, struct kernel_param *kp)
> > +static int phram_init_called;
> > +static __initdata char phram_paramline[64+12+12];
>
> snip..
> > +static int phram_setup(const char *val, struct kernel_param *kp)
> > +{
>
> snip..
>
> > +     strlcpy(phram_paramline, val, sizeof(phram_paramline));
>
> Accessing __initdata from non __init function. Please check that your
> patch does not introduce a new section mismatch. There is even a kernel
> config option to debug these issues.

I enabled DEBUG_SECTION_MISMATCH but I don't get errors. Also, this
part of the code will never be reached once init has run. If you think
that it's a risk, then I can remove the __initdata keyword.

Hervé
--
Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve
Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920



More information about the linux-mtd mailing list