[smatch stuff] mtd/ubi/gluebi: signedness warnings
Dan Carpenter
dan.carpenter at oracle.com
Mon Oct 10 05:28:57 EDT 2011
Smatch complains about some to the checks in gluebi.c
drivers/mtd/ubi/gluebi.c +177 gluebi_read(6) warn: unsigned 'len' is never less than zero.
drivers/mtd/ubi/gluebi.c +221 gluebi_write(6) warn: unsigned 'len' is never less than zero.
drivers/mtd/ubi/gluebi.c +270 gluebi_erase(7) warn: unsigned 'instr->len' is never less than zero.
I think probably these checks can just be removed? Can these things
wrap if we passed a huge value for instr->len?
270 if (instr->len < 0 || instr->addr + instr->len > mtd->size)
271 return -EINVAL;
I don't know enough about how these are called to say.
regards,
dan carpenter
More information about the linux-mtd
mailing list