[patch v2] mtd/docg3: dereferencing an ERR_PTR() in docg3_probe()

Robert Jarzmik robert.jarzmik at free.fr
Tue Nov 29 17:00:09 EST 2011


Dan Carpenter <dan.carpenter at oracle.com> writes:

> If doc_probe_device() returned an ERR_PTR, then we accidentally saved
> that to docg3_floors[floor] = mtd; which gets derefenced in the error
> handling when we call doc_release_device().
>
> I've reworked the error handling to take care of that and hopefully
> make it a little simpler.
>
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> ---
> v2: Version 1 conflicted with another patch in stream.
Ok, applied and tested locally (even if that branch of code obviously is not
triggered in my case), and everything should work even better with it.

Acked-by: Robert Jarzmik <robert.jarzmik at free.fr>

Cheers.

--
Robert



More information about the linux-mtd mailing list