[PATCH] mtd: ndfc: fix typo in structure dereference

Dmitry Eremin-Solenikov dbaryshkov at gmail.com
Tue Nov 22 03:56:43 EST 2011


On 11/22/11, Tony Breeds <tony at bakeyournoodle.com> wrote:
> In commit 9d7948c50055e74b693ce9e99a709b2e5bbc1942 (mtd: ndfc: use
> ofpart through generic parsing) we dereference a non pointer type
> causing the following compiler error:
> drivers/mtd/nand/ndfc.c: In function 'ndfc_chip_init':
> drivers/mtd/nand/ndfc.c:191: error: invalid type argument of '->' (have
> 'struct mtd_part_parser_data')
>
> Fix that.
>
> Signed-off-by: Tony Breeds <tony at bakeyournoodle.com>

Acked-by: Dmitry Eremin-Solenikov <dbaryshkov at gmail.com>

Sometimes I wander about this serie. I tried to test most
of the combinations, I could test at that momemt. The patches
were split in simple chunks to simplify review and testing. They
waited in linux-next for 2 or 3 releases. And I still see problems
with those patches.


> ---
>  drivers/mtd/nand/ndfc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand/ndfc.c
> index ee17139..f8aacf4 100644
> --- a/drivers/mtd/nand/ndfc.c
> +++ b/drivers/mtd/nand/ndfc.c
> @@ -188,7 +188,7 @@ static int ndfc_chip_init(struct ndfc_controller *ndfc,
>  	if (!flash_np)
>  		return -ENODEV;
>
> -	ppdata->of_node = flash_np;
> +	ppdata.of_node = flash_np;
>  	ndfc->mtd.name = kasprintf(GFP_KERNEL, "%s.%s",
>  			dev_name(&ndfc->ofdev->dev), flash_np->name);
>  	if (!ndfc->mtd.name) {
> --
> 1.7.6.4
>
> Yours Tony
>


-- 
With best wishes
Dmitry



More information about the linux-mtd mailing list