[PATCH 0/2] small mtd-utils fixes

Brian Norris computersforpeace at gmail.com
Wed Nov 16 15:03:55 EST 2011


These two fixes are somewhat trivial, although the second one fixes a
kind of regression that occurred since the last release.

Speaking of releases: when will we make a new release? After kernel 3.2
is final? Or perhaps a pre-3.2 and post-3.2 release? There are a lot of
important fixes in git right now, and I'd like to incorporate them

Also, note that the following commit was intended to be paired with the
commits in the "brian" branch:

    commit bf01f2960ba82468b1b25f00e044fd0c3ee0770a
    nandwrite: consolidate buffer usage

While it is functionally harmless, it does include an unnecessary
memcpy(). In fact, the patch really is useful only when paired with the
rest of the 'brian' branch, which is intended for kernels supporting
ioctl(MEMWRITE) - i.e., kernel version >= 3.2.

So I recommend that the next release either includes the 'brian' branch
or does not include commit bf01f2. Mike Frysinger and I discussed this
issue on the ML earlier and didn't really come up with a solution that
avoids the overhead both with and without MEMWRITE. I figure pre-3.2
kernel users will just have to put up with it eventually.


Brian Norris (2):
  mtd-utils: add jffs2reader to .gitignore
  mtdinfo: provide info when used without arguments

 .gitignore          |    1 +
 ubi-utils/mtdinfo.c |   14 ++++++++++----
 2 files changed, 11 insertions(+), 4 deletions(-)


More information about the linux-mtd mailing list