[PATCH 07/26] ubifs: remove unnecessary dentry_unhash from rmdir, dir rename

Sage Weil sage at newdream.net
Fri May 27 16:42:00 EDT 2011


ubifs does not have problems with references to unlinked directories.

CC: Artem Bityutskiy <dedekind1 at gmail.com>
CC: Adrian Hunter <adrian.hunter at nokia.com>
CC: linux-mtd at lists.infradead.org
Signed-off-by: Sage Weil <sage at newdream.net>
---
 fs/ubifs/dir.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index d80810b..7217d67 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -656,8 +656,6 @@ static int ubifs_rmdir(struct inode *dir, struct dentry *dentry)
 	struct ubifs_inode *dir_ui = ubifs_inode(dir);
 	struct ubifs_budget_req req = { .mod_dent = 1, .dirtied_ino = 2 };
 
-	dentry_unhash(dentry);
-
 	/*
 	 * Budget request settings: deletion direntry, deletion inode and
 	 * changing the parent inode. If budgeting fails, go ahead anyway
@@ -978,9 +976,6 @@ static int ubifs_rename(struct inode *old_dir, struct dentry *old_dentry,
 			.dirtied_ino_d = ALIGN(old_inode_ui->data_len, 8) };
 	struct timespec time;
 
-	if (new_inode && S_ISDIR(new_inode->i_mode))
-		dentry_unhash(new_dentry);
-
 	/*
 	 * Budget request settings: deletion direntry, new direntry, removing
 	 * the old inode, and changing old and new parent directory inodes.
-- 
1.7.0




More information about the linux-mtd mailing list