[PATCH 2/2] UBIFS: fix-up free space on mount if flag is set
Artem Bityutskiy
dedekind1 at gmail.com
Fri May 13 03:58:33 EDT 2011
On Thu, 2011-05-12 at 14:09 +0300, Artem Bityutskiy wrote:
> On Fri, 2011-05-06 at 18:58 -0400, Matthew L. Creech wrote:
> > + if (c->space_fixup) {
> > + err = ubifs_fixup_free_space(c);
> > + if (err)
> > + goto out;
> > + }
> > +
> > dbg_gen("re-mounted read-write");
> > c->remounting_rw = 0;
> > err = dbg_check_space_info(c);
>
> Note, I've moved the 'ubifs_fixup_free_space()' a bit down to make sure
> we first print "re-mounted" and "deferred recovery completed" messages,
> and then start fixing up. I think this is a bit neater.
I do not know if that was me or you, but I've found out that the a lot
of code uses spaces for indentation instead of tabs, and checkpatch.pl
complains:
WARNING: please, no spaces at the start of a line
#119: FILE: fs/ubifs/sb.c:746:
+ err = PTR_ERR(lprops);$
ERROR: code indent should use tabs where possible
#120: FILE: fs/ubifs/sb.c:747:
+ goto out;$
.... a lot of this ....
But I've just fixed this.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
More information about the linux-mtd
mailing list