[PATCH v3 2/3] ubifs: add ubifs_fixup_free_space()

Matthew L. Creech mlcreech at gmail.com
Fri May 6 11:18:17 EDT 2011


On Fri, May 6, 2011 at 11:02 AM, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
>> +
>> +     ubifs_assert(len >= 0);
>> +     ubifs_assert(len % c->min_io_size == 0);
>
> So if this is true.
>
>> +
>> +     /* Pad if necessary */
>> +     aligned_len = ALIGN(len, c->min_io_size);
>> +     if (aligned_len > len) {
>
> This will be always false and the below code can be removed, right?
>

Oh, yes you're right - I added it before you had mentioned that the
lengths would be min_io_size-aligned.  :)  Thanks

-- 
Matthew L. Creech



More information about the linux-mtd mailing list