[PATCH V2 06/10] MIPS: lantiq: add NOR flash support

John Crispin john at phrozen.org
Mon Mar 28 10:15:28 EDT 2011


On 07/03/11 13:25, John Crispin wrote:
> On 07/03/11 09:58, Artem Bityutskiy wrote:
>> On Tue, 2011-03-01 at 17:13 +0100, John Crispin wrote:
>>   
>>> NOR flash is attached to the same EBU (External Bus Unit) as PCI. As described
>>> in the PCI patch, the EBU is a little buggy, resulting in the upper and lower
>>> 16 bit of the data on a 32 bit read are swapped. (essentially we have a addr^=2)
>>>
>>> To work around this we do a addr^=2 during the probe. Once probed we adapt
>>> cfi->addr_unlock1 and cfi->addr_unlock2 to represent the endianess bug.
>>>
>>> Changes in V2
>>> * handle the endianess bug inside the map code and not in the generic cfi code
>>> * remove the addr swizzle patch
>>>
>>> Signed-off-by: John Crispin <blogic at openwrt.org>
>>> Signed-off-by: Ralph Hempel <ralph.hempel at lantiq.com>
>>> Cc: David Woodhouse <dwmw2 at infradead.org>
>>> Cc: Daniel Schwierzeck <daniel.schwierzeck at googlemail.com>
>>> Cc: linux-mips at linux-mips.org
>>> Cc: linux-mtd at lists.infradead.org
>>>     
>> There are a couple checkpatch.pl warnings, would you please address them
>> and resend?
>>
>>   
> Hi,
> 
> of course.
> 
> thanks,
> John
> 
> 

Hi,

i fixed one of the warnings. the remaining warning wants me to put at
least 4 lines into the help section in the Kconfig. However 3 lines were
enough to explain what the driver does.

John





More information about the linux-mtd mailing list