[PATCH 1/1] ubifs: debugfs operations may return both ERRs and NULLs

Artem Bityutskiy dedekind1 at gmail.com
Wed Mar 23 08:41:56 EDT 2011


On Wed, 2011-03-23 at 11:51 +0200, Phil Carmody wrote:
> I knew I invented IS_ERR_OR_NULL for something, and this was probably
> it. NULL has lost all information about what the error was, and the most
> appropriate error code is ENODEV. However, that's the only error code
> that the debugfs functions can return. So basically, any error = ENODEV.
> 
> Signed-off-by: Phil Carmody <ext-phil.2.carmody at nokia.com>

The debugfs code may change and gain more error codes, so I do not think
it is good idea to treat any error as ENODEV. I think only NULL should
be translated to ENODEV instead.

I'll try to re-work your patch accordingly and push it unless you send a
new one.

Thanks!

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)




More information about the linux-mtd mailing list