[PATCH] NAND: DaVinci: Removed header file that is not required

Artem Bityutskiy dedekind1 at gmail.com
Mon Mar 7 12:57:52 EST 2011


On Mon, 2011-03-07 at 08:57 -0600, Paulraj, Sandeep wrote:
> > 
> > On Tue, 2011-03-01 at 17:40 -0500, s-paulraj at ti.com wrote:
> > > From: Sandeep Paulraj <s-paulraj at ti.com>
> > >
> > > The DaVinci NAND driver was including the mach-types.h header
> > > file.
> > > This prevented the DaVinci NAND driver from getting used
> > > in a DSP only device. The linux port on c6x devices can make
> > > use of the same driver and does not define a corresponding
> > > header file; so removing it.
> > >
> > > Signed-off-by: Sandeep Paulraj <s-paulraj at ti.com>
> > 
> > Hi,
> > 
> > you explain why this include is bad for DSP. Buy you do not explain
> why
> > this include is there and why removing it is harmless for Linux.
> > 
> 
> Hi,
> 
> This header file was required in the driver because earlier there was
> code dependent on a machine_* check. This piece of code has now been
> factored out and is in /arch/arm/mach-davinci/aemif.c.
> 
> Thus removing it is harmless.
> 
> Please do let me know if you need an updated patch.

Yes, please, patch description should contain this important
information.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)




More information about the linux-mtd mailing list