[PATCHv2] UBI: clarify the volume notification types' doc

Artem Bityutskiy dedekind1 at gmail.com
Thu Jun 23 10:51:36 EDT 2011


On Mon, 2011-06-20 at 17:34 +0200, David Wagner wrote:
> I realized the new descriptions of ADDED and REMOVED could also be
> misleading: they can also be triggered after using a userland util
> (ubi{mk,rm}vol).
> 
> (the indentation looks odd but is fine once the patch has been applied)
> 
> Signed-off-by David Wagner <david.wagner at free-electrons.com>
> ---
>  include/linux/mtd/ubi.h |   12 +++++++-----
>  1 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/mtd/ubi.h b/include/linux/mtd/ubi.h
> index b31bd9e..b79e741 100644
> --- a/include/linux/mtd/ubi.h
> +++ b/include/linux/mtd/ubi.h
> @@ -134,11 +134,13 @@ struct ubi_device_info {
> 
>  /*
>   * enum - volume notification types.
> - * @UBI_VOLUME_ADDED: volume has been added
> - * @UBI_VOLUME_REMOVED: start volume volume
> - * @UBI_VOLUME_RESIZED: volume size has been re-sized
> - * @UBI_VOLUME_RENAMED: volume name has been re-named
> - * @UBI_VOLUME_UPDATED: volume name has been updated
> + * @UBI_VOLUME_ADDED: a volume has been added (containing device attached
> + *		      or volume created from a userland util)
> + * @UBI_VOLUME_REMOVED: a volume has been removed (containing device
> detached

The patch is corrupted because of line-wrapping, but I fixed it and
amended the comments a bit (did not like the "userland util" phrase),
and pushed to ubi-2.6.git tree, thanks.

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list