[PATCH v2 2/4] mtd: nand: convert printk() to pr_*()
Artem Bityutskiy
dedekind1 at gmail.com
Thu Jun 9 04:13:14 EDT 2011
Brian, would you please send a new series? I suggest you the following
order of things.
1. clean-up of non-DEBUG() messages.
1.1. go through all printks and check if KERN_* is ok, fix. E.g.,
I can see that all KERN_DEBUG should become KERN_INFO
1.2. go through all printks and check if the function name prefix
makes sense there - kill those which do not.
Also, while doing this, keep in mind that messages will be later
turned into dev_* (dev_info(), dev_err(), etc) so they will be
automatically prefixed with the device name which is already some
identification of the source of the message.
1.3. turn messages to dev_*
1.4. make another pass and do all the lines consolidations,
alignments, punctuation, etc etc.
2. clean-up of DEBUG() cruft.
2.1 change DEBUG() with dev_dbg()
Kill all function name prefixes as well. The rationale is: dev_dbg()
already adds function name prefixe (and process id) if dynamic
debugging is enabled. In case of debugging with DEBUG macro, you
anyway have to change the code (adding #define DEBUG) so you might
easily defind pr_fmt at the same time for youself.
How does this sound to you?
FWIW: I've moved the patches I pushed from the master branch to the
"brian" branch of l2-mtd-2.6.git tree. But they will not be useful
for you, I guess.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
More information about the linux-mtd
mailing list