[PATCH v2] libmtd: add helper funcs for getting regioninfo and locked info
Artem Bityutskiy
dedekind1 at gmail.com
Wed Jun 8 07:52:46 EDT 2011
On Tue, 2011-06-07 at 11:28 -0400, Mike Frysinger wrote:
> This extends the libmtd with the helper functions:
> mtd_regioninfo: interface to MEMGETREGIONINFO
> mtd_islocked: interface to MEMISLOCKED
>
> Users of these functions will follow shortly ...
>
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
Pushed with a small tweak, thanks!
> +int mtd_islocked(const struct mtd_dev_info *mtd, int fd, int eb)
> +{
> + int ret;
> + erase_info_t ei;
> +
> + ei.start = eb * mtd->eb_size;
> + ei.length = mtd->eb_size;
> +
> + ret = ioctl(fd, MEMISLOCKED, &ei);
> + if (ret < 0)
> + return mtd_ioctl_error(mtd, eb, "MEMISLOCKED");
> +
I've removed this error message - if we fail, better return an error
code silently. At least your next patch is built a way that it will keep
iterating and executing this function.
We might as well print an error message if (!ENOTTY && !ENOTSUPP), but I
did not do this. I expect you to send a correction patch if you do not
like this :-)
Thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
More information about the linux-mtd
mailing list