[PATCH 4/6] libmtd: add helper funcs for getting fds, regioninfo, and locked info
Artem Bityutskiy
dedekind1 at gmail.com
Tue Jun 7 02:50:36 EDT 2011
On Tue, 2011-06-07 at 02:19 -0400, Mike Frysinger wrote:
> +int mtd_open_dev1(int mtd_num)
> +{
> + char devpath[128];
> + int fd;
> +
> + sprintf(devpath, "/dev/mtd%i", mtd_num);
> + fd = open(devpath, O_RDONLY | O_CLOEXEC);
> + if (fd < 0)
> + return sys_errmsg("cannot open \"%s\"", devpath);
> +
Could we avoid hard-coding device node names?
We indeed have -m option in mtdutils which opens a device by its number.
But I think it was a mistake. Generally, MTD devices can have any name,
it is up to udev configuration. So I'd rather deprecate and would
require a list of device node names.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
More information about the linux-mtd
mailing list