[PATCH] mtd: OneNAND: Fix wrong subpage_sft at 4KiB pagesize

Artem Bityutskiy dedekind1 at gmail.com
Mon Jun 6 06:06:31 EDT 2011


On Mon, 2011-06-06 at 13:02 +0300, Artem Bityutskiy wrote:
> On Mon, 2011-06-06 at 09:42 +0000, roman.tereshonkov at nokia.com wrote:
> > What do mean by "no case to use the subpage"?
> > 
> > According to the spec KFM4G16Q4M-xEBx the Number of Partial Program Cycles in the page (NOP)
> > is equal to 4 -> subpage_sft=2.
> 
> I thought this means "not supported by HW". But if this is supported,
> then I'm very surprised why would we remove it. I'm dropping this patch
> from my tree.

OK, I actually did not put it to the l2 tree. And AFAICS this patch
basically reverts commit 99b17c08bca2810f5910b3027f1b9d82edf7a576, but
still leaves the data structures like onenand_oob_128.

So NACK for this patch - poor commit message, weird changes. I'm
surprised to see this from kmpark.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)




More information about the linux-mtd mailing list