[PATCH] mtd: OneNAND: Fix wrong subpage_sft at 4KiB pagesize

[roman.tereshonkov at nokia.com]

>-----Original Message-----
>From: ext Artem Bityutskiy [mailto:dedekind1 at gmail.com] 
>Sent: 03 June, 2011 18:42
>To: Kyungmin Park; Tereshonkov Roman (Nokia-SD/Helsinki)
>Cc: linux-mtd at lists.infradead.org; dwmw2 at infradead.org; 
>m.szyprowski at samsung.com
>Subject: Re: [PATCH] mtd: OneNAND: Fix wrong subpage_sft at 
>4KiB pagesize
>
>On Thu, 2011-06-02 at 15:48 +0900, Kyungmin Park wrote:
>> From: Kyungmin Park <kyungmin.park at samsung.com>
>> 
>> There's no case to use the subpage for 4KiB pagesize.
>> 
>> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
>> ---
>> diff --git a/drivers/mtd/onenand/onenand_base.c 
>b/drivers/mtd/onenand/onenand_base.c
>> index ac9e959..337be7c 100644
>> --- a/drivers/mtd/onenand/onenand_base.c
>> +++ b/drivers/mtd/onenand/onenand_base.c
>> @@ -4047,13 +4047,11 @@ int onenand_scan(struct mtd_info 
>*mtd, int maxchips)
>>  	 */
>>  	switch (mtd->oobsize) {
>>  	case 128:
>> -		if (FLEXONENAND(this)) {
>> +		if (FLEXONENAND(this))
>>  			this->ecclayout = &flexonenand_oob_128;
>> -			mtd->subpage_sft = 0;
>> -		} else {
>> +		else
>>  			this->ecclayout = &onenand_oob_128;
>> -			mtd->subpage_sft = 2;
>> -		}
>> +		mtd->subpage_sft = 0;
>>  		break;
>>  	case 64:
>>  		this->ecclayout = &onenand_oob_64;
>
>Roman, are you happy with this change?
>


What do mean by "no case to use the subpage"?

According to the spec KFM4G16Q4M-xEBx the Number of Partial Program Cycles in the page (NOP)
is equal to 4 -> subpage_sft=2.

Regards
Roman Tereshonkov

>-- 
>Best Regards,
>Artem Bityutskiy (Артём Битюцкий)
>
>