[PATCH 06/10] UBIFS: fix memory leak on error path

Artem Bityutskiy dedekind1 at gmail.com
Fri Jun 3 09:49:57 EDT 2011

From: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>

UBIFS leaks memory on error path in 'ubifs_jnl_update()' in case of write
failure because it forgets to free the 'struct ubifs_dent_node *dent' object.
Although the object is small, the alignment can make it large - e.g., 2KiB
if the min. I/O unit is 2KiB.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
Cc: stable at kernel.org
 fs/ubifs/journal.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
index 34b1679..cef0460 100644
--- a/fs/ubifs/journal.c
+++ b/fs/ubifs/journal.c
@@ -669,6 +669,7 @@ out_free:
 	release_head(c, BASEHD);
+	kfree(dent);
 	ubifs_ro_mode(c, err);
 	if (last_reference)

More information about the linux-mtd mailing list