On Wed, 2011-06-01 at 08:49 +0100, Marc Zyngier wrote:
> On Tue, 2011-05-31 at 22:20 -0400, Mike Frysinger wrote:
> > On Tue, May 31, 2011 at 17:44, Marc Zyngier wrote:
> > > On Tue, 31 May 2011 23:11:14 +0400 Sergei Shtylyov wrote:
> > >> Marc Zyngier wrote:
> > >> > In the process of moving platforms away from integrator-flash
> > >> > (aka armflash), add to physmap the few features that make
> > >> > armflash unique:
> > >>
> > >> > - optionnal probing for the AFS partition type
> > >> > - init() and exit() methods, used by Integrator to control
> > >> > write access to the various onboard programmable components
> > >>
> > >> > Signed-off-by: Marc Zyngier <marc.zyngier at arm.com>
> > >> > Acked-by: Catalin Marinas <catalin.marinas at arm.com>
> > >> > Cc: David Woodhouse <dwmw2 at infradead.org>
> > >> [...]
> > >>
> > >> > diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h
> > >> > index bcfd9f7..d37cca0 100644
> > >> > --- a/include/linux/mtd/physmap.h
> > >> > +++ b/include/linux/mtd/physmap.h
> > >> > @@ -22,6 +22,8 @@ struct map_info;
> > >> >
> > >> > struct physmap_flash_data {
> > >> > unsigned int width;
> > >> > + int (*init)(struct platform_device *);
> > >> > + void (*exit)(struct platform_device *);
> > >>
> > >> How about a declaration for 'struct platform_device' beforehand? This breaks
> > >> build on other platforms at least...
> > >
> > > Sure. Please send a patch.
> >
> > uhh, what ? you broke things, so you fix them. i already pointed out
> > this breakage to you over a week ago.
>
> Mike,
>
> Sorry I missed your earlier comment about this. My bad.
>
> Now, about my reply to Sergei:
> * Sergei identified the problem, and proposed a valid fix. It's
> only fair he gets credited for his work (yes, you did it before
> he did, but I didn't know it). The SOB on a patch is the proper
> way of managing the attribution.
> * Posting a patch is the quickest way for the maintainer (in this
> case David) to be able to push a fix to mainline.
> * It also helps other folks reading the ML and facing the same
> issue. They can grab the patch, apply it locally and go on with
> their own stuff until the patch is merged.
> * The person reporting the problem probably has a configuration
> showing the problem. If any of my platforms had shown that
> error, I would have fixed it long before it hit the mailing
> list.
>
> Now, to keep everyone happy, an untested patch. David, can you please
> apply it?
>
> Cheers,
>
> M.
>
> >From 1440a857e119b90df68e87cf9da87fce870c86cf Mon Sep 17 00:00:00 2001
> From: Marc Zyngier <marc.zyngier at arm.com>
> Date: Wed, 1 Jun 2011 08:37:28 +0100
> Subject: [PATCH] MTD: Fix physmap compilation error
>
> Commit b7281ca2a4 (MTD: Add integrator-flash feature to physmap)
> broke some platforms by using 'struct platform_device' without
> declaring it.
>
> Add a forward declaration to keep everyone happy.
>
> Fix proposed by both Mike Frysinger and Sergei Shtylyov.
The first person who sent a patch was Randy, so we already have the
patch, now it is only about merging it.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)