[PATCH 3/4] MTD: pxa3xx_nand: enable multiple chip select support
adrian.wenl at gmail.com
Thu Jul 7 02:26:23 EDT 2011
Hi Igor && Daniel,
On Wed, Jul 6, 2011 at 3:41 PM, Igor Grinberg <grinberg at compulab.co.il> wrote:
> On 07/04/11 12:25, Lei Wen wrote:
>> #ifdef CONFIG_PM
>> @@ -1203,8 +1259,12 @@ static int pxa3xx_nand_resume(struct platform_device *pdev)
>> struct pxa3xx_nand_info *info = platform_get_drvdata(pdev);
>> - nand_writel(info, NDTR0CS0, info->host->ndtr0cs0);
>> - nand_writel(info, NDTR1CS0, info->host->ndtr1cs0);
>> + /*
>> + * Directly set the chip select to a invalid value,
>> + * then the driver would reset the timing according
>> + * to current chip select at the beginning of cmdfunc
>> + */
>> + info->cs = 0xff;
> Thinking of this for the second (or third) time,
> If you have keep config enabled and have only one nand chip,
> this will brake the keep config...
> have you tested the suspend/resume with this patch?
> (and keep_config on?)
Do you still have concern with this change?
If not, I would push the next round of patch set including merging
patch 3 and 4.
More information about the linux-mtd