[PATCH] physmap: fix mtdconcat support if physmap/mtdconcat were compiled as modules

Stefan Roese sr at denx.de
Mon Jan 10 05:58:29 EST 2011


On Wednesday 05 January 2011 10:07:53 Artem Bityutskiy wrote:
> On Wed, 2011-01-05 at 05:00 +0300, Dmitry Eremin-Solenikov wrote:
> > physmap/physmap_of contained compile-time check for mtd concatenation.
> > However thos modules did not consider that mtd concatenation can be
> > built as modules. Fix physmap/physmap_of to also support
> > CONFIG_MTD_CONCAT=m

<snip>

> Can we do something else to avoid these complex ifdefs? I'd vote for
> making mtdconcat integral part of mtd core and just always have it
> built-in - remove the Kconfig option and all the ifdefs all over the
> place. Indeed, this is tiny piece of code, I believe this micro-modules
> make little sense nowadays.

Yes, I like this suggestion.

Dmitry, can you cook up such a patch? Otherwise I'll put it on my to-do 
list...
 
> The same for mtdparts - but this is a different story.

Yep.

Cheers,
Stefan



More information about the linux-mtd mailing list