[PATCH v7 4/7] omap3: nand: prefetch in irq mode support

Ghorai, Sukumar s-ghorai at ti.com
Tue Jan 4 03:50:17 EST 2011



[..snip...]
> > +		if (info->buf_len & (info->buf_len < bytes))
> 
> Meant to use logical AND here?
[Ghorai] thanks, you are right.

[..snip..]
> > +	init_completion(&info->comp);
> 
> You can use INIT_COMPLETION to reset the completion variable.
> Same change can be done in write below.
[..snip..]
> s/methode/method
> 
[Ghorai] yes. I will do this 

[..snip..]
> > +	/* waiting for write to complete */
> > +	wait_for_completion(&info->comp);
> > +	/* wait for data to flushed-out before reset the prefetch */
> > +	do {
> > +		ret = gpmc_read_status(GPMC_PREFETCH_COUNT);
> > +	} while (ret);
> 
> Please have a timeout for this while loop in case hardware does
> not become ready. Also, consider using cpu_relax() inside the
> tight loop.
> 
[Ghorai] Thanks. I will send again.




More information about the linux-mtd mailing list