[PATCH] fsmc-nand: Add fsmc_nand_set_plat_data in linux/mtd/fsmc.h

Artem Bityutskiy dedekind1 at gmail.com
Fri Feb 25 06:12:20 EST 2011


On Fri, 2011-02-25 at 16:41 +0530, viresh kumar wrote:
> On 02/25/2011 04:37 PM, Artem Bityutskiy wrote:
> > On Fri, 2011-02-25 at 09:14 +0530, viresh kumar wrote:
> >> > On 02/24/2011 06:08 PM, Linus Walleij wrote:
> >>> > > 2011/2/23 Viresh Kumar <viresh.kumar at st.com>:
> >>> > > 
> >>>>> > >> > In most of the cases partitions info, width, etc comes from board files. And
> >>>>> > >> > device structure may be defined in machine files, common to all board files.
> >>>>> > >> > Thus, we need to set platform data from board file, for which
> >>>>> > >> > fsmc_nand_set_plat_data routine is required.
> >>> > > Hm you create a new function, but where is it used? If it's used by a later
> >>> > > patch perhaps you should make a patch series instead?
> >> > 
> >> > Linus,
> >> > 
> >> > Actually it will be used in SPEAr patches, which will be sent separately. I could
> >> > have kept it as part of that series also, but just thought to send it separately.
> >> > You want me to keep it in spear patch series instead?
> > I think this is important piece of information which should be in the
> > patch commit message.
> 
> Ok. I will resend it.

To elaborate, imagine I put this patch to my l2 tree, then David has the
same question when he decides whether to pick it or not.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)




More information about the linux-mtd mailing list