[PATCH 3/3] mtd: Add mtdswap block driver

Artem Bityutskiy dedekind1 at gmail.com
Fri Feb 18 09:14:30 EST 2011


On Mon, 2011-02-14 at 16:16 +0200, Jarkko Lavinen wrote:
> +config MTD_SWAP_STRICT
> +       bool "Strict erase error handling"
> +       depends on MTD_SWAP
> +       help
> +        Enables strict tolerance on failed erasures, marking erase blocks bad
> +        right after the first failed operation. With non-strict mode the
> +        erase operation is retried. 

This is too small thing to deserve a separate config option. And the
help text does not explain what for is this needed, what's the problem
with re-trying the erase operation - it looks like over-design.

Is it please possible to remove this config option?

Otherwise I'm fine with the patches, thanks! I'm putting them to my l2
tree but I wait an updated version from you without this option. In the
worst case, if you can prove the need for this option, make it a module
parameter instead please.

Thanks a lot! This is good stuff and I know it works.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)




More information about the linux-mtd mailing list