[PATCH] mtd-utils: common.h: simple_strtoll type usage
Brian Norris
computersforpeace at gmail.com
Tue Feb 15 20:47:58 EST 2011
We must use "long long" and "unsigned long long" types when
implementing the functions "simple_strtoll()" and "simple_strtoull()",
respectively. This prevents casting/truncation errors on systems where
"long" is not the same size as "long long" (that is, on most systems).
Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
include/common.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/common.h b/include/common.h
index eb8d5fc..2e5c2a0 100644
--- a/include/common.h
+++ b/include/common.h
@@ -108,9 +108,9 @@ static inline type simple_##func(const char *snum, int *error) \
return ret; \
}
simple_strtoX(strtol, long int)
-simple_strtoX(strtoll, long int)
+simple_strtoX(strtoll, long long int)
simple_strtoX(strtoul, unsigned long int)
-simple_strtoX(strtoull, unsigned long int)
+simple_strtoX(strtoull, unsigned long long int)
#include "xalloc.h"
--
1.7.0.4
More information about the linux-mtd
mailing list