Numonyx NOR and chip->mutex bug?

[Michael Cashwell]

On Feb 11, 2011, at 10:39 AM, Joakim Tjernlund wrote:

>>> I'm wondering if the blocks being written to are in a properly erased state.
>> 
>> Yes, it's a possibility. However, I've never seen an erase report any error.
> 
> Mike, does this small patch change anything:
> diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c
> index 9772a62..bdcd8c1 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0001.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0001.c
> @@ -808,7 +808,8 @@ static int chip_ready (struct map_info *map, struct flchip *chip, unsigned long
> 		     (mode == FL_WRITING && (cfip->SuspendCmdSupport & 1))))
> 			goto sleep;
> 
> -
> +		/* Numonyx Axcell chips needs a Read Status */
> +		map_write(map, CMD(0x70), adr);
> 		/* Erase suspend */
> 		map_write(map, CMD(0xB0), adr);

No, this doesn't change the failures I see.

-Mike