[PATCH] UBIFS: Kernel oops on a read only mounted file system

[Artem Bityutskiy]

On Tue, 2011-12-13 at 08:53 +0100, Daniel Fahlgren wrote:
> Neither the kernel nor the ubifs system is the latest, but the code in
> ubifs_write_inode hasn't changed since 2008-something.
> 
> Looking at the list there is another similar report[1] but that isn't in
> the same place. Attached is a patch that fixes the problem for me. To be
> honest is my local version slightly different and is checking for
> inode->i_sb->s_flags & MS_RDONLY and not c->ro_mount. I'm not sure if it
> is in the correct place regarding locks, or if the check should be in
> ubifs_jnl_write instead.

I think this patch fixes the symptom, not the real cause. Most probably
it is a VFS bug in your kernel. If UBIFS is R/O, it should never have
any dirty inodes, so there should be nothing to write!

What is your kernel version? Can you enable generic UBIFS debugging and
collect the UBIFS prints and send them? Use ignore_loglevel kernel
argument when booting to make sure all UBIFS output goes to your
console, otherwise you'll not see them there and they will end up in the
ring buffer, and will probably overlap.

Thanks!

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20111217/e5f78042/attachment.sig>