[PATCH] mtd: nand: write bad block marker even with BBT

[Artem Bityutskiy]

On Mon, 2011-12-12 at 13:53 -0800, Brian Norris wrote:
> On Mon, Dec 12, 2011 at 12:49 PM, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> > On Wed, 2011-12-07 at 13:08 -0800, Brian Norris wrote:
> >> Add and option (NAND_BBT_WRITE_BBM) for writing bad block markers to
> >> proper OOB area on each block in addition to flash-based BBT. This is
> >> useful when:
> >>
> >>  * bootloader cannot read the flash-based BBT format
> >>  * BBT is corrupted and the flash must be rescanned for bad
> >>    blocks; we want to remember bad blocks that were marked from Linux
> >>
> >> Adapted from code by Matthieu CASTET.
> >>
> >> Cc: Matthieu CASTET <matthieu.castet at parrot.com>
> >> Signed-off-by: Brian Norris <computersforpeace at gmail.com>
> >
> > 2 questions, perhaps silly, but still:
> >
> > 1. Why wouldn't you make this the only and the default behavior? Why
> > adding more options instead?
> 
> Personally, I'd like it to be default behavior. I guessed that it may
> cause incompatibility with some other system which depended on the
> current behavior, but if that's not a realistic concern, then I don't
> mind dropping the option. It's also possible to add a flag to restore
> the old behavior if needed in the future.

Right, I do not see that it will likely break older systems. I suggest
making this the only behavior, unless someone spots a problem with this.

You could send a new patch, and put into CC major MTD contributors
obtained with git-log, for example. If they have concerns, they can
rise the flag. How does this sound to you?


-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20111217/6ad67c39/attachment.sig>