[PATCH (mtd-www) 02/13] nand-data: updates to S30ML-P devices

[Brian Norris]

On Tue, Dec 6, 2011 at 4:07 AM, Angus CLARK <angus.clark at st.com> wrote:
> Updates to Spansion S30ML-P devices:
>        - expand names to differentiate between x8 and x16 devices

Expanding the names is probably good, but I don't really like the
"-FI{00,50}" piece. There are a few places where I used a wildcard in
the table to represent "don't care" characters. I think a lower-case
`x' might make sense, for example:

S30ML512P30-FIx0
S30ML512P50-FIx1
S30ML256P30-FIx0
...

Or perhaps a hyphen, which I think the datasheet is already using as a
don't care marker:

S30ML512P30-FI-0
S30ML512P50-FI-1
S30ML256P30-FI-0
...

Whichever way we go (hyphen or `x') should be standardized across the
table from now on.

>        - fix ID 5th byte: 0x01 to 0x10 (checked with datasheet; seems regression
>          introduced as part of commit 165cfaa9cdb1054bbafa98f24f179c6aa101fbe6
>          "nand-data: remove asterisks")

Hmm, not exactly a regression, but I overlooked it when merging in
changes to my local table. In fact, I have a data sheet that lists the
ID with 0x01, but it may be out of date. It's hard to find a current
one from Spansion's website, although a random copy I found off a
third party site confirms your given string, I think. Then, there's a
posting from Gernot Hoyler last year that gives this sample string.
It's slightly different (at id_data[2]):

   id_data[0]=0x01
   id_data[1]=0x56
   id_data[2]=0x00
   id_data[3]=0x01
   id_data[4]=0x10
   id_data[5]=0x00
   id_data[6]=0x00
   id_data[7]=0x00

I'm thinking:

id_data[2] = 0x00 or 0x01, depending on model as stated in data sheet.
I just ignored the 0x00 option.
id_data[4] = 0x10

Anyway, it may be apparent by now that I don't actually have a sample
of this chip myself. I'll go with whoever has a current data sheet
and/or actual chip.

Brian