[PATCH 3/5] mtd: remove MEMSETOOBSEL macro definition

[Artem Bityutskiy]

On Wed, 2011-08-24 at 14:28 +0200, Ricard Wanderlof wrote:
> On Wed, 24 Aug 2011, Brian Norris wrote:
> 
> > MEMSETOOBSEL is completely unused and useless. Remove the definition.
> >
> > Note: it's probably best not to use this ioctl number in the future for
> > MTD, since that may cause conflicts between old kernels and new user
> > software (or new kernels and old user software). This shouldn't be much
> > problem.
> 
> Perhaps this should be noted as a comment in the code, rather than just 
> removing the line. Such information tends to get forgotten sooner or later 
> otherwise.

Yeah, I've amended the patch and added a comment:

+/*
+ * Note, the following ioctl existed in the past and was removed:
+ * #define MEMSETOOBSEL           _IOW('M', 9, struct nand_oobinfo)
+ * Try to avoid adding a new ioctl with the same ioctl number.
+ */

-- 
Best Regards,
Artem Bityutskiy