[PATCH 1/3] mtd_debug: report ecc layout

Ben Gardiner bengardiner at nanometrics.ca
Mon Aug 22 09:11:32 EDT 2011


On Mon, Aug 22, 2011 at 7:00 AM, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> On Thu, 2011-08-18 at 10:01 -0400, Ben Gardiner wrote:
>> Fair enough -- I'm happy to hear a definitive answer; thank you, Artem.
>>
>> In PATCH 3/3 I use the same ioctl to get the ECC size for the purposes
>> of producing a BER estimate. What is the right way of getting the ECC
>> size now that ECCGETLAYOUT is deprecated? Is this even something that
>> should be from userspace at all?
>
> I do not know. I think we need to expose it via sysfs. I think that in
> general sysfs is better that "informational" ioctls.

Ok -- I've heard that said before and for what it's worth I agree --
sysfs is better.

However, I'm seeing that there is no available sysfs mechanism at
present. I'm sorry but I can't take on the time to introduce one
although I agree it is best and I would like to be able to.

Please drop patches 1/3 and 3/3 from consideration. Patch 2/3 'print
number of bits corrected during test' is still useful and applicable
to mtd-utils -- IMHO.

Best Regards,
Ben Gardiner

---
Nanometrics Inc.
http://www.nanometrics.ca



More information about the linux-mtd mailing list