[RFC 4/5] mtd: move mtd_oob_mode_t to shared kernel/user space

Artem Bityutskiy dedekind1 at gmail.com
Mon Aug 22 04:50:22 EDT 2011


On Wed, 2011-08-17 at 16:50 -0700, Brian Norris wrote:
> +/*
> + * oob operation modes
> + *
> + * MTD_OOB_PLACE:       oob data are placed at the given offset
> + * MTD_OOB_AUTO:        oob data are automatically placed at the free areas
> + *                      which are defined by the ecclayout
> + * MTD_OOB_RAW:         mode to read oob and data without doing ECC checking
> + */
> +typedef enum {
> +	MTD_OOB_PLACE,
> +	MTD_OOB_AUTO,
> +	MTD_OOB_RAW,
> +} mtd_oob_mode_t;

Could we get rid of this typedef and use anonymous enum instead:

enum {
	A,
	B,
};

Indeed, we do not need it, and we do not want to pollute the user-space
namespaces unnecessarily.

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list