[PATCH 1/3] mtd_debug: report ecc layout

Ben Gardiner bengardiner at nanometrics.ca
Thu Aug 18 10:01:16 EDT 2011


On Wed, Aug 17, 2011 at 4:03 AM, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> On Tue, 2011-08-09 at 16:57 -0400, Ben Gardiner wrote:
>> The mtd_debug 'info' command reports a great deal of useful information about
>> the mtd device is it given for a query.
>>
>> Add the ECC size and OOB available to that list. The other entries in the
>> ecclayout struct are arrays and are not as meaningful as eccsize and oobavail.
>>
>> Signed-off-by: Ben Gardiner <bengardiner at nanometrics.ca>
>>
>> ---
>>
>> I noticed that the struct nand_ecclayout_user and its corresponding ioctl
>> has been marked deprecated; however, since this is a 'debug' utility and at
>> least one person found it useful I thought it would be a good idea to propose
>> these changes anyways.
>
> I think we could just kill depricated ioctls as soon as we make
> mtd-utils stop using them. If you add this dependency - it will be more
> difficult to kill them.

Fair enough -- I'm happy to hear a definitive answer; thank you, Artem.

In PATCH 3/3 I use the same ioctl to get the ECC size for the purposes
of producing a BER estimate. What is the right way of getting the ECC
size now that ECCGETLAYOUT is deprecated? Is this even something that
should be from userspace at all?

Best Regards,
Ben Gardiner

---
Nanometrics Inc.
http://www.nanometrics.ca



More information about the linux-mtd mailing list