[PATCH] mtdinfo: don't open NULL pointer when getting region_info with `-a'

Brian Norris computersforpeace at gmail.com
Fri Aug 5 18:59:21 EDT 2011


Hi (other) Brian,

On Fri, Aug 5, 2011 at 12:29 AM, Brian Foster <brian.foster at maxim-ic.com> wrote:
>  I suggest adding some round brackets:
>
>        if (!args.node || (!args.map && mtd->region_cnt == 0))
>
>  Less confusing.  Otherwise, looks Ok
>  to me (not actually built or tested).

Thanks for the comment. But I'm guessing this patch isn't the best
idea after all (unless Mike's plan doesn't work).

Anyway, it'd probably help if you test the final product, since you're
the one who actually sees the error!

Thanks,
Brian



More information about the linux-mtd mailing list