UBI memory usage on large page nand

Artem Bityutskiy dedekind1 at gmail.com
Wed Apr 20 03:30:33 EDT 2011


Hi,

On Wed, 2011-04-20 at 11:19 +0800, Nicholas wrote:
> Dear Artem,
> 
> Sorry for my late reply .

Please, send proper Linux kernel patches. Hints:

1. Make a separate patch pere change, so that on modification is done by
one patch. In your case, one buffer improvement pere patch.
2. Write good commit message.
3. Use git format-patch to create patches.

> 
> #define MTD_SMALL_SIZE_PAGE_BLOCK_SIZE	0x40000 // block size for 2KB

No, please just make buffer size to be ubi->max_write_size. Kill this
constant.

> orphan.c
> In ubifs_mount_orphans()
> c->orph_buf = vmalloc((c->leb_size)/4); // for temporary

Similarly, just use ubi->max_write_size instead.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)




More information about the linux-mtd mailing list