[PATCHv3 1/3] mkfs.jffs2: fix casting of __off64_t

Mike Frysinger vapier.adi at gmail.com
Tue Apr 19 10:38:12 EDT 2011


On Tue, Apr 19, 2011 at 10:29, Andy Shevchenko wrote:
> On Tue, 2011-04-19 at 10:26 -0400, ext Mike Frysinger wrote:
>> On Tue, Apr 19, 2011 at 04:34, Andy Shevchenko wrote:
>> > -                                       printf("\ts %04o %9lu             %5d:%-3d %s\n",
>> > +                                       printf("\ts %04o %" PRIu64 "             %5d:%-3d %s\n",
>>
>> is there a reason for dropping the field width ?  printf("%9"PRIu64"
>> .....") should work fine ...
>
> If you guarantee the value not higher than 10^10, why should we use
> PRIu64 at all? It's enough to have cast to unsigned long in such case.

it's a *minimum* field width, not a maximum.  it makes sure the output
is aligned properly for most people.
-mike



More information about the linux-mtd mailing list