[PATCH 1/2] atmel_nand: add missing include of linux/dmaengine.h

[Artem Bityutskiy]

On Wed, 2011-04-13 at 15:55 +0200, Hans-Christian Egtvedt wrote:
> Including linux/dmaengine.h fixes the missing definition of the enum
> dma_ctrl_flags type used in atmel_nand_dma_op function.
> 
> Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt at atmel.com>

I do not see how it is a problem. C does not support strict types
checking anyway. This all is just 'int'.

IMHO, the enums you invented only make code less readable for C
programmers.

I'd suggest to turn all you enums into anonymous enums and stop using
them as types. That would only make things more readable and easier to
follow.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)