[PATCH v5 2/4] MTD : add the common code for GPMI controller driver

Lothar Waßmann LW at KARO-electronics.de
Thu Apr 14 02:38:52 EDT 2011


Hi,

Huang Shijie writes:
> >> +	this->swap_block_mark = true;
> >> +	if (GPMI_IS_MX23(this))
> >> +		this->swap_block_mark = false;
> >>
> > if ... else ...?
> else is "true" by default.
>
I meant it would be clearer to do:
	if (GPMI_IS_MX23(this))
		this->swap_block_mark = false;
	else
		this->swap_block_mark = true;


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________



More information about the linux-mtd mailing list