Oops when calling fsync on read-only file-system
Reuben Dowle
Reuben.Dowle at navico.com
Mon Apr 11 21:32:50 EDT 2011
On my system, calling the fsync system call on any file in a UBI file-system that is mounted read-only leads to a kernel oops. Our system is running a customise version of 2.6.31, but as far as I can see (without testing which is not possible due to extensive vendor customisation of .31 kernel version), the current git branch also contains this bug.
I have created a patch against 2.6.31 that fixes the problem in my system. Perhaps someone could test on latest kernel version.
Signed-off-by: Reuben Dowle <reuben.dowle at navico.com>
---
--- linux-2.6.31.orig/fs/ubifs/io.c 2009-09-10 10:13:59.000000000 +1200
+++ linux-2.6.31/fs/ubifs/io.c 2011-04-11 15:43:50.026527002 +1200
@@ -916,6 +916,14 @@
{
int i, err = 0;
+ /* If this is a read-only mount, write buffers will be null
+ * Skip the sync, returning success (even though this is an invalid operation
+ * on a read-only file-system, return success because all data on flash
+ * is up to date)
+ */
+ if(!c->jheads)
+ return 0;
+
for (i = 0; i < c->jhead_cnt; i++) {
struct ubifs_wbuf *wbuf = &c->jheads[i].wbuf;
---
More information about the linux-mtd
mailing list