[PATCH v4] Retry Large Buffer Allocations
Artem Bityutskiy
dedekind1 at gmail.com
Fri Apr 8 09:08:58 EDT 2011
On Thu, 2011-04-07 at 10:40 -0700, Grant Erickson wrote:
> When handling user space read or write requests via mtd_{read,write}
> or JFFS2 medium scan requests, exponentially back off on the size of
> the requested kernel transfer buffer until it succeeds or until the
> requested transfer buffer size falls below the page size.
>
> This helps ensure the operation can succeed under low-memory,
> highly-fragmented situations albeit somewhat more slowly.
>
> v2: Incorporated coding style and comment feedback from Artem.
> v3: Incorporated more feedback from Artem. Retargeted patch against
> l2-mtd-2.6.
> v4: Incorporated feedback from Artem about compilation on 64-bit
> architectures.
>
> Signed-off-by: Grant Erickson <marathon96 at gmail.com>
> ---
> drivers/mtd/mtdchar.c | 50 +++++++++++++++++++++-------------------------
> drivers/mtd/mtdcore.c | 41 ++++++++++++++++++++++++++++++++++++++
> fs/jffs2/scan.c | 19 ++++++++++-------
> include/linux/mtd/mtd.h | 2 +
> 4 files changed, 77 insertions(+), 35 deletions(-)
Ideally, you should have split this on 3 patches and send a series, but
well, I already kind of said that were the last requests, so I do not
push for this. I've just taken this to my l2-mtd-2.6.git.
But if you can, please split the patch on 3 patches:
1. Introduces mtd_kmalloc_up_to - explain the reasons we need this func.
2. Start using it in mtdcore
3. Start using it in JFFS2
This is nicer way.
But if you do not do this, I do not mind. Thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
More information about the linux-mtd
mailing list