[PATCH 1/3] mtd-utils: new memory wrappers

Mike Frysinger vapier at gentoo.org
Thu Sep 30 21:43:53 EDT 2010

On Thu, Sep 30, 2010 at 02:01, Artem Bityutskiy wrote:
> On Thu, 2010-09-30 at 01:59 -0400, Mike Frysinger wrote:
>> On Thu, Sep 30, 2010 at 01:48, Artem Bityutskiy wrote:
>> > On Thu, 2010-09-30 at 01:15 -0400, Mike Frysinger wrote:
>> >> as i'm sure you noticed, i didnt make these up.  i simply moved them
>> >> from existing mtd-utils code.
>> >
>> > Actually no, I did not notice!
>> np ... only one or two utils uses this, and easy enough to convert
>> them.  before i go further though, a question on direction ...
>> mkfs.jffs2 has a lot of helpers that can be moved to common.h.  but it
>> implements things using C functions & va_args.  the common.h header
>> takes the CPP approach of expanding the variable args.  which way to
>> go to ultimately unify the code base !?
> I have not strong opinion, how about creating common.c ?

ok, i played a bit with a common.c.  ultimately, i could not get it to
be smaller than a CPP approach on my x86_64 system.  so i'll stick
with the CPP stuff.

More information about the linux-mtd mailing list