[PATCH RESEND][MTD]MLC device check in OneNAND driver

Artem Bityutskiy dedekind1 at gmail.com
Fri Sep 24 07:52:04 EDT 2010


On Fri, 2010-09-24 at 17:10 +0530, Rohit Hassan Sathyanarayan wrote:
> Signed-off-by: Rohit HS <rohit.hs at samsung.com>
> Signed-off-by: Raghav Gupta <gupta.raghav at samsung.com>

Almost perfect. However:

1. All mtd patches should have "mtd:" prefix.
2. Add some description about what you do and why into the commit
message.
3. I think combining is not good, better do it old way - first patch
introduces the flag, second uses it in OneNAND

Sorry for being picky, but I really want to show you how to send patches
properly once and later get good series from you.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)




More information about the linux-mtd mailing list