[PATCH v2 3/3][MTD] P4080/mtd: Fix the freescale lbc issue with 36bit mode

Timur Tabi timur.tabi at gmail.com
Mon Sep 13 10:35:14 EDT 2010


On Mon, Sep 13, 2010 at 9:27 AM, Artem Bityutskiy <dedekind1 at gmail.com> wrote:

> Yes, sizeof(int) == 4 assumption is not good.
>
> But sizeof(int) >= 4 is perfectly fine.

I have to disagree.   I don't see how you can say that == is not okay,
but >= is okay.  That just doesn't make any sense.  Obviously, you
have to make some assumptions about sizeof(int), but that assumption
should be nothing more than "it should be big enough for these small
numbers that I'm using".

> I see people use u32 and the friends too much.

I agree with that.

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the linux-mtd mailing list